[FIX] _revert_method: ensure origin method is set only if it exists#1580
Open
rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
Open
[FIX] _revert_method: ensure origin method is set only if it exists#1580rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR corrige el hook de desinstalación para que _revert_method() solo intente restaurar el método original cuando el método actual realmente expone el atributo origin, evitando fallos si el monkey patch no se aplicó (o si el método ya fue restaurado).
Changes:
- Ajuste defensivo en
_revert_method()para leermethod.originde forma segura congetattr(..., None). - Evita
AttributeErroral desinstalar cuando el método no fue parcheado.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.