Skip to content

[FIX] mail_log_only_internal: refactor search #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
augusto-weiss wants to merge 1 commit into from
Closed

[FIX] mail_log_only_internal: refactor search #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 3 additions & 37 deletions mail_log_only_internal/models/res_partner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,9 @@ class ResPartner(models.Model):
_inherit = "res.partner"

def _get_allowed_partner_ids(self):
all_users = self.env["res.users"].search([("active", "=", True)])
internal_users = all_users.filtered(lambda u: u.has_group("base.group_user") and u.partner_id).mapped(
"partner_id.id"
)
internal_group = self.env.ref("base.group_user")
internal_users = internal_group.all_user_ids.mapped("partner_id.id")
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal_group.all_user_ids.mapped('partner_id.id') probablemente incluye usuarios inactivos y puede introducir False si algún usuario no tiene partner_id. Esto cambia el comportamiento respecto a la versión anterior (que filtraba active=True y u.partner_id) y puede permitir menciones a partners archivados. Filtraría all_user_ids por activos y mapearía a partner_id (recordset) para obtener .ids sin falsy.

Suggested change
internal_users = internal_group.all_user_ids.mapped("partner_id.id")
internal_users = (
internal_group.all_user_ids.filtered(lambda u: u.active and u.partner_id)
.mapped("partner_id")
.ids
)

Copilot uses AI. Check for mistakes.

allow_ids_str = (
self.env["ir.config_parameter"].sudo().get_param("mail_log_only_internal.allow_log_partner_ids", "[]")
)
Expand All @@ -34,36 +33,3 @@ def _get_mention_suggestions_domain(self, search):
domain = super()._get_mention_suggestions_domain(search)
allowed_partner_ids = self._get_allowed_partner_ids()
return Domain.AND([domain, [("id", "in", allowed_partner_ids)]])

@api.model
def _search_mention_suggestions(self, domain, limit, extra_domain=None):
allowed_partner_ids = self._get_allowed_partner_ids()
domain = Domain.AND([domain, [("id", "in", allowed_partner_ids)]])
return super()._search_mention_suggestions(domain, limit, extra_domain)

@api.model
def get_mention_suggestions(self, search, limit=8):
result = super().get_mention_suggestions(search, limit)
allowed_partner_ids = self._get_allowed_partner_ids()
if isinstance(result, dict) and "res.partner" in result:
filtered_partners = [
partner for partner in result["res.partner"] if partner.get("id") in allowed_partner_ids
]
result["res.partner"] = filtered_partners
if "hr.employee" in result:
allowed_employees = (
self.env["res.partner"].browse(allowed_partner_ids).mapped("user_ids.employee_ids.id")
)
result["hr.employee"] = [emp for emp in result["hr.employee"] if emp.get("id") in allowed_employees]
if "res.users" in result:
allowed_users = self.env["res.partner"].browse(allowed_partner_ids).mapped("user_ids.id")
result["res.users"] = [user for user in result["res.users"] if user.get("id") in allowed_users]
return result

@api.model
def _search_for_channel_invite(self, store, search_term, channel_id=None, limit=30):
result = super()._search_for_channel_invite(store, search_term, channel_id, limit)
allowed_partner_ids = self._get_allowed_partner_ids()
result["partner_ids"] = [pid for pid in result.get("partner_ids", []) if pid in allowed_partner_ids]
result["count"] = len(result["partner_ids"])
return result