Skip to content

[FIX] export_bg: Handle import_compat parameter correctly in background export #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rov-adhoc wants to merge 1 commit into from
Closed

[FIX] export_bg: Handle import_compat parameter correctly in background export #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions export_bg/models/export_bg_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,18 @@ def _export_chunk_bg(self, data, export_id, export_format):
]
)

field_names = [f.get("name") or f.get("value") or f.get("id") for f in params["fields"]]
field_labels = [f.get("label") or f.get("string") for f in params["fields"]]
# Extract field names considering import_compat mode
import_compat = params.get("import_compat", True)
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import_compat está defaulteando a True. Si el front envía import_compat como undefined, JSON.stringify omite la clave y acá se activaría el modo import-compatible por defecto (cambiando headers a técnicos y la extracción). Para evitar regresiones, sería más seguro defaultear a False (comportamiento “export normal”) o normalizar explícitamente el valor (p.ej. bool(params.get('import_compat')) con default False).

Suggested change
import_compat = params.get("import_compat", True)
import_compat = params.get("import_compat", False)

Copilot uses AI. Check for mistakes.

# For field_names (data extraction), always use the technical field name
# Only use 'value' as fallback when import_compat=True (for import compatibility)
if import_compat:
field_names = [f.get("name") or f.get("value") or f.get("id") for f in params["fields"]]
field_labels = field_names # Use field names as headers for import compatibility
else:
# When not import_compat, use only 'name' or 'id' for field_names, not 'value'
Comment on lines +45 to +51
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El comentario dice “siempre usar el nombre técnico del campo”, pero en el branch import_compat todavía se hace fallback a value/id. Para evitar confusión futura, ajustaría el comentario para reflejar exactamente la cadena de fallback que se está aplicando en cada modo.

Suggested change
# For field_names (data extraction), always use the technical field name
# Only use 'value' as fallback when import_compat=True (for import compatibility)
if import_compat:
field_names = [f.get("name") or f.get("value") or f.get("id") for f in params["fields"]]
field_labels = field_names # Use field names as headers for import compatibility
else:
# When not import_compat, use only 'name' or 'id' for field_names, not 'value'
# Modo import_compat: para field_names usar name -> value -> id,
# y reutilizar esos mismos nombres como cabeceras para mantener compatibilidad de import.
if import_compat:
field_names = [f.get("name") or f.get("value") or f.get("id") for f in params["fields"]]
field_labels = field_names # Use field names as headers for import compatibility
else:
# Modo normal (no import_compat): para field_names usar name -> id
# y para field_labels usar label -> string (etiquetas legibles para el usuario).

Copilot uses AI. Check for mistakes.
field_names = [f.get("name") or f.get("id") for f in params["fields"]]
field_labels = [f.get("label") or f.get("string") for f in params["fields"]]

export_data = self.export_data(field_names).get("datas", [])

Expand Down
Loading