[FIX] account_payment_pro: Matched amount based in payment_type#925
Open
feg-adhoc wants to merge 1 commit intoingadhoc:18.0from
Open
[FIX] account_payment_pro: Matched amount based in payment_type#925feg-adhoc wants to merge 1 commit intoingadhoc:18.0from
feg-adhoc wants to merge 1 commit intoingadhoc:18.0from
Conversation
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR corrige un bug en el cálculo del signo del monto conciliado (matched_amount) en pagos. El problema estaba en que se utilizaba partner_type (customer/supplier) para determinar el signo, cuando debería usarse payment_type (inbound/outbound) que representa correctamente la dirección del pago.
Changes:
- Cambio de
partner_type == "supplier"apayment_type == "outbound"en el cálculo del signo dentro de_compute_matched_amounts
Comment on lines
+472
to
475
| sign = rec.payment_type == "outbound" and -1.0 or 1.0 | ||
| rec.matched_amount = sign * sum( | ||
| rec.matched_move_line_ids.with_context(matched_payment_ids=rec.ids).mapped("payment_matched_amount") | ||
| ) |
There was a problem hiding this comment.
Aunque el fix es correcto, sería recomendable agregar tests que validen el cálculo de matched_amount para diferentes combinaciones de payment_type y partner_type, especialmente casos edge como:
- Pagos outbound a customers (devoluciones)
- Pagos inbound de suppliers (notas de crédito)
Esto ayudaría a prevenir regresiones futuras de este bug que se está corrigiendo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.