[FIX] account_payment_pro: Ensure company_id change validation only occurs if original company_id is set#922
Closed
rov-adhoc wants to merge 1 commit intoingadhoc:18.0from
Closed
Conversation
…ccurs if original company_id is set
Contributor
|
|
There was a problem hiding this comment.
Pull request overview
Este PR corrige un problema en el método _onchange_company_id del modelo account.payment. El método ejecutaba remove_all() incorrectamente al crear nuevos registros de pago, ya que la condición self.company_id != self._origin.company_id siempre se evaluaba como verdadera cuando _origin.company_id estaba vacío (registros nuevos).
Changes:
- Se añade una verificación adicional
self._origin.company_idantes de comparar el cambio de compañía, asegurando que el método solo limpie las líneas a pagar cuando realmente hay un cambio de compañía en un registro existente, no en registros nuevos.
Contributor
|
@roboadhoc r+ nobump |
roboadhoc
pushed a commit
that referenced
this pull request
Feb 23, 2026
…ccurs if original company_id is set closes #922 Signed-off-by: Camila Vives <cav@adhoc.inc>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.