-
Notifications
You must be signed in to change notification settings - Fork 14
Playbook to push CK data file file into loki storage #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Generate synthetic data and write results to a json file Push json file to log directory so that during debug file is available for review Controller/ci-framework-data/tests/feature-verification-tests Do not overwrite syth data json if it already exists Using Gemini and Cursor Closes https://issues.redhat.com/browse/OSPRH-23746
Update the synthetic data generation process to ensure that existing JSON files are not overwritten. This change allows for better debugging by preserving previous data outputs. Closes https://issues.redhat.com/browse/OSPRH-23746
cc5d1f1 to
09fd308
Compare
|
recheck with depends on set for PR #331 so that we can validate with the latest changes in my PR. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Generate synthetic data and write results to a json file Push json file to log directory so that during debug file is available for review Controller/ci-framework-data/tests/feature-verification-tests Do not overwrite syth data json if it already exists Using Gemini and Cursor Closes https://issues.redhat.com/browse/OSPRH-23746 Update the synthetic data generation process to ensure that existing JSON files are not overwritten. This change allows for better debugging by preserving previous data outputs. Closes https://issues.redhat.com/browse/OSPRH-23746
d556ca0 to
18827d0
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a952612e61b743b097cfdefada704bf0 ✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 1h 59m 54s |
|
tempest tests failed.. recheck |
|
recheck |
Generate synthetic data and write results to a json file Push json file to log directory so that during debug file is available for review Controller/ci-framework-data/tests/feature-verification-tests Do not overwrite syth data json if it already exists Using Gemini and Cursor Closes https://issues.redhat.com/browse/OSPRH-23746 Update the synthetic data generation process to ensure that existing JSON files are not overwritten. This change allows for better debugging by preserving previous data outputs. Closes https://issues.redhat.com/browse/OSPRH-23746
vyzigold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started to review. This quite confusing to review. I see this includes content from #331 and also it seems there are duplicated files inside this PR (see my other comment, the files roles/telemetry_chargeback/files/loki_data_templ.j2 and roles/telemetry_chageback/template/loki_data_templ.j2 is another example).
So it seems to me like this is still very much in progress. I can continue a review after some cleanup.
Generate synthetic data and write results to a json file Push json file to log directory so that during debug file is available for review Controller/ci-framework-data/tests/feature-verification-tests Do not overwrite syth data json if it already exists Using Gemini and Cursor Closes https://issues.redhat.com/browse/OSPRH-23746 Update the synthetic data generation process to ensure that existing JSON files are not overwritten. This change allows for better debugging by preserving previous data outputs. Closes https://issues.redhat.com/browse/OSPRH-23746
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3117a6b15d3f421d8bfd47fa5f2686ed ❌ telemetry-openstack-meta-content-provider-master FAILURE in 8m 20s |
|
PR#331 is merged now.. I have resolved all conflicts now |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7e21966dfd684648a1f2887abf8e529a ❌ telemetry-openstack-meta-content-provider-master FAILURE in 7m 19s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0261ea1a92614640b6686abe130272d3 ❌ telemetry-openstack-meta-content-provider-master FAILURE in 7m 35s |
|
recheck |
1 similar comment
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2b765787c5484f9c93f18d81ae0c803d ❌ telemetry-openstack-meta-content-provider-master FAILURE in 9m 04s |
|
recheck |
ayefimov-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked the new tests and the results. Everything seems to be working correct. Nice job.
e7202ed to
68751ca
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
So many conflicts in this PR and I have added 1 more file to retreive data from loki. Please look at #334 |
Playbook "roles/telemetry_chargeback/tasks/ingest_loki_data.yml" takes up synthetic data file (json) from Cloudkitty and pushes it to loki server