Add conversational entity linking into REL#150
Merged
stefsmeets merged 16 commits intomainfrom Jan 24, 2023
Merged
Conversation
4 tasks
We have no way of testing, because the data are not available
Contributor
Author
|
Hi @chriskamphuis and @hideaki-j I think this PR is pretty much done, could you have a look at it and let me know what you think? |
Contributor
|
@hideaki-j Can you look at this, as you created CREL, I am not familiar with it |
Contributor
|
I have skimmed through the changes of CREL parts, and it seems to be OK (Stef and I had a meeting about this and I have already shared this with him 😉) I will take the time to check the documentation and test etc in detail when I find time but I think it is good to move to the next step for now. |
Contributor
Author
|
Hi @hideaki-j @chriskamphuis, if you are happy with the changes, don't forget to press the 'Approve changes' button, so that the code can be merged :-) |
chriskamphuis
approved these changes
Jan 23, 2023
hideaki-j
approved these changes
Jan 23, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements converstational entity linking from @hideaki-j into REL.
First I refactored the CREL code (see informagi/conversational-entity-linking-2022#1). I left the code as-is as much as possible, and tried to depend on functions already in REL where possible. Then I copied all the code over into
./src/REL/crel.I added some tests and documentation for the new CREL functions.
I also refactored the server to use fastapi/pydantic (in #147 so you can see the changes). I then branched this off #147, which makes it much easier to implement the conversational entity linking into the server. Note that the API itself did not change, I just added conversational entity linking to it. Fastapi/pydantic will make it much easier to update the API later on.
To check out the server working, see
./scripts/test_server.pyfor an example.Todo
-> Revisit when Mention detection with Bert #151 is merged
Follow-up:
bert_md.pyonce Mention detection with Bert #151 gets merged.