Skip to content

Conversation

@p16i
Copy link
Collaborator

@p16i p16i commented Dec 18, 2019

Hi,

This pull-request introduces a couple of changes that make this module installable via pip.
Consequently, one can install this module and try the notebook (#5 ) on Google Colab:
https://colab.research.google.com/drive/1A-_kRAszK65xUyaYSKT31TewP-CoogJv.

Could you please provide me the details below?

  • name
  • description
  • author (and email)

So, I can update the details in this PR.

Related #6

@jarauh jarauh self-assigned this Jan 16, 2020
@jarauh
Copy link
Collaborator

jarauh commented Jan 16, 2020

Thanks for your work! I will figure out a good author and email address.

Name: "admUI"
Description: "This package provides functions to compute the function UI introduced in by Bertschinger et al. ["Quantifying unique information", Entropy 2014, 16(4), 2161-2183]."

@jarauh
Copy link
Collaborator

jarauh commented Jan 16, 2020

Could you please make dit an optional requirement? The feature name could also be "dit".

@jarauh
Copy link
Collaborator

jarauh commented Jan 31, 2020

Thanks, @heytitle ! I added the author information now.

The following works with this:

> pip3 install ${path to directory that contains setup.py}
> pip3 install --user https://github.com/heytitle/computeUI/archive/pipable.zip

(Note to self: the .zip-file is conveniently auto-generated by Github.)

I first thought that it may make sense to move setup.py to the python subdirectory? But I guess that in this case, the second line (installing from the autogenerated zip-file) would not work anymore, right? So I believe that it is good as it is.

@jarauh
Copy link
Collaborator

jarauh commented Jan 31, 2020

Pat, feel free to merge.

After the merge, we should amend the README.md, to include the second pip3 statement (with the then correct path).

@p16i p16i merged commit 407ce3c into infodeco:master Feb 3, 2020
@p16i p16i deleted the pipable branch February 3, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants