Conversation
Codecov Report
@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 74.42% 73.59% -0.84%
==========================================
Files 164 164
Lines 15588 14389 -1199
==========================================
- Hits 11601 10589 -1012
+ Misses 3177 2933 -244
- Partials 810 867 +57
Continue to review full report at Codecov.
|
|
Needs to annotate some common errors with grpc Status codes |
pdpserver/server/service.go
Outdated
|
|
||
| b := s.pool.Get() | ||
| msg.Body = s.rawValidateToBuffer(p, c, in.Body, b) | ||
| body, err := s.rawValidateToBuffer(p, c, in.Body, b) |
There was a problem hiding this comment.
Here you define new err variable, which shadows existing one. Can you make sure that this doesn't break existing logic, e.g. validatePostHook logic?
| })}) | ||
| } else { | ||
| err = stream.Send(&pb.Msg{Body: s.rawValidateToBuffer(p, c, in.Body, buffer)}) | ||
| body, err := s.rawValidateToBuffer(p, c, in.Body, buffer) |
There was a problem hiding this comment.
Here you define new err variable, which shadows existing one. Can you make sure that this doesn't break existing logic, e.g. now external err is not updated with the error coming from Send. Consider renaming the new error variable to avoid ambiguity.
2 participants
No description provided.