fix: add missing explicit lifetime for rust 1.83 build

[chenrui333]

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

• ✏️ Write a PR description, regardless of triviality, to include the value of this PR
• 🔗 Reference related issues
• 🏃 Test cases are included to exercise the new code
• 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
• 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

---

👋 This PR is fixing the regression build issue against rust 1.83.0:

  error: elided lifetime has a name
     --> flux-core/src/ast/walk/mod.rs:183:47
      |
  181 | impl<'a> Node<'a> {
      |      -- lifetime `'a` declared here
  182 |     #[allow(missing_docs)]
  183 |     pub fn from_expr(expr: &'a Expression) -> Node {
      |                                               ^^^^ this elided lifetime gets resolved as `'a`
      |
  note: the lint level is defined here
     --> flux-core/src/lib.rs:1:38
      |
  1   | #![cfg_attr(feature = "strict", deny(warnings, missing_docs))]
      |                                      ^^^^^^^^
      = note: `#[deny(elided_named_lifetimes)]` implied by `#[deny(warnings)]`
  
  error: elided lifetime has a name
    --> flux-core/src/parser/mod.rs:44:37
     |
  42 | impl<'input> Parser<'input> {
     |      ------ lifetime `'input` declared here
  43 |     /// Instantiates a new parser with the given string as input.
  44 |     pub fn new(src: &'input str) -> Parser {
     |                                     ^^^^^^ this elided lifetime gets resolved as `'input`

• relates to rust 1.83.0 Homebrew/homebrew-core#199379
• fixes 0.195.2 failed to build against rust 1.83.0 #5515

[chenrui333]

can someone review and merge this patch? Thanks!

cc @btasker @mhilton @crepererum @sanderson 🙏

[crepererum]

thank you

[crepererum]

@chenrui333 could you rebase this change so we can have a fresh CI run? Sorry for the late feedback.

[chenrui333]

@crepererum just rebased to the latest master. 👍

[mhilton]

@chenrui333 This looks to me like it needs make generate running in order to satisfy the tests. I have taken the liberty of doing so in #5522 (mostly to test it). If you want to run make generate yourself and update this PR then go ahead, otherwise I'll merge my updated one in a few days.

[chenrui333]

sorry about the late reply (not quite familiar with the process, but that works for me :) )

[mhilton]

sorry about the late reply (not quite familiar with the process, but that works for me :) )

No worries, just wanted to make sure you got your change merged.