-
Notifications
You must be signed in to change notification settings - Fork 322
Docs/5625 v1 get query endpoint #6274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Compat.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Compat.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ompat.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ompat.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jstirnaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small, but important suggestions. Otherwise, looks good. Thanks for doing this!
api-docs/influxdb3/cloud-dedicated/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-dedicated/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-dedicated/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-serverless/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/clustered/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
…ompat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…ompat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…ompat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…ompat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…Compat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
jstirnaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these necessary?
Yes. InfluxQL is correct
api-docs/influxdb3/cloud-serverless/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
…Compat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…ta/docs-v2 into docs/5625-v1-get-query-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds GET and POST endpoint support for the /query endpoint to the InfluxDB v1 compatibility API documentation across three InfluxDB 3 products. The main purpose is to document both GET and POST query methods for the v1 HTTP API and update terminology from "bucket" to "database" for consistency.
Key changes:
- Added comprehensive GET
/queryendpoint documentation with parameters, headers, and response schemas - Enhanced POST
/queryendpoint with JSON request body schema - Updated terminology from "bucket" to "database" throughout the documentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| api-docs/influxdb3/clustered/v1-compatibility/swaggerV1Compat.yml | Added GET query endpoint and enhanced POST endpoint with JSON schema; updated bucket→database terminology |
| api-docs/influxdb3/cloud-serverless/v1-compatibility/swaggerV1Compat.yml | Added GET query endpoint and enhanced POST endpoint with JSON schema; updated bucket→database terminology |
| api-docs/influxdb3/cloud-dedicated/v1-compatibility/swaggerV1Compat.yml | Added GET query endpoint and enhanced POST endpoint with JSON schema; updated bucket→database terminology |
api-docs/influxdb3/cloud-serverless/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-serverless/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/clustered/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
…Compat.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Compat.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jstirnaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving the v1-compat docs. My suggestions add explanation about
- DBRP mapping and the differences between Cloud Serverless and Cloud Dedicated/Clustered. I realized we need to do a better job making this explicit for anyone looking to migrate from v1.
- Use of "bucket" in Cloud Serverless. Sorry if my earlier comment misled you. Cloud Serverless still uses "bucket" to be consistent with Cloud v2 terminology.
api-docs/influxdb3/cloud-dedicated/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-dedicated/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-dedicated/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-serverless/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-serverless/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-serverless/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/cloud-dedicated/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/clustered/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
api-docs/influxdb3/clustered/v1-compatibility/swaggerV1Compat.yml
Outdated
Show resolved
Hide resolved
jstirnaman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do this in the other specs as well, but that's a separate issue.
…ompat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…ompat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…ompat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…Compat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…Compat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…Compat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…ompat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
…Compat.yml Co-authored-by: Jason Stirnaman <stirnamanj@gmail.com>
Closes #6271
Closes #6272
Closes #5625
Adding GET & POST/query endpoint to cloud-serverless, dedicated, and cluster swagger