Fixed GetTop commands from the Tag Api#176
Open
eivanmariscal wants to merge 1 commit intoinflatablefriends:nextfrom
Open
Fixed GetTop commands from the Tag Api#176eivanmariscal wants to merge 1 commit intoinflatablefriends:nextfrom
eivanmariscal wants to merge 1 commit intoinflatablefriends:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lastfm's documentation is off for these endpoints:
Documentation says that it should return a "topalbums" and "toptracks" object respectively but it's actually returning "albums" and "tracks".
This is related to issue #172 and this PR fixes that.
There was another bug in the tag.getTopTags command.
For this endpoint Lastfm doesn't return an URL object and this was throwig a NullReferenceException in the LastTag constructor. I added an overloaded constructor to fix the problem.