Skip to content

#595 Fix fieldHideLabel being unconditionally passed in block components#599

Open
iruzevic wants to merge 1 commit intomainfrom
feature/595-fix-field-hide-label
Open

#595 Fix fieldHideLabel being unconditionally passed in block components#599
iruzevic wants to merge 1 commit intomainfrom
feature/595-fix-field-hide-label

Conversation

@iruzevic
Copy link
Member

Description

Fixed:

  • Input, date, phone, rating, and textarea components: fieldHideLabel was always being passed (even as false), which overrode the field component's own default hide-label behavior. It is now extracted into a $fieldOutput array and only set conditionally when explicitly true.
  • Removed unused missingType.generics PHPStan ignore rule.

QA Guide

Steps for QA to test this feature:

  1. Open a form with input, date, phone, rating, and textarea fields that have the Hide label option disabled
  2. Verify the label is visible for all those field types
  3. Enable Hide label on each field type and verify the label is hidden correctly
  4. Confirm no regressions in form submission behaviour

Expected result: Labels show/hide correctly based on the field setting, with no unintended overrides.

Screenshots / Videos

Productive ticket

#595 (comment)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@iruzevic iruzevic requested a review from a team March 13, 2026 15:47
@iruzevic iruzevic self-assigned this Mar 13, 2026
@iruzevic iruzevic linked an issue Mar 13, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] - Country label shown even if hidden

1 participant