forked from FuelLabs/fuel-connectors
-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ci): update Playwright versions for E2E tests #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guimroque
wants to merge
161
commits into
main
Choose a base branch
from
p2/feat/bako-predicate-connector
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs instead of all lowercase
…nnector using the minimum necessary packages
…e bako safe vault instead
… cleanup - Add skipVersionSelection flag to bypass predicate version modal - Clear Privy localStorage and cookies on disconnect for fresh logins
- Check both user.wallet and embeddedWallet for address detection - Clear only bako_connector_personal_wallet on disconnect - Allow fresh login with different account without manual cache clear
…cases Handle scenarios where Privy automatic wallet creation fails or is interrupted. Clear stale sessions before login to prevent invalid OTP code errors from corrupted session state.
Wait for auth state to stabilize before checking wallet, and ensure clean logout before showing login modal to prevent email linking errors.
The localStorage cleanup for Bako connector keys is essential to maintain state synchronization between Privy and the connector. Without it, stale data causes authentication conflicts when reconnecting. Also updates the Social Login icon to a modern email envelope design. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Override accounts() and isConnected() to wait for Privy to be ready before checking stored account. This prevents the race condition where SDK queries these methods before Privy session is restored from iframe. Also adds logout before sendCode() to prevent cannot_link_more_of_type error when switching email accounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
playwright@1.48.2(chromium-1140 for Synpress) andplaywright@1.57.0(chromium-1200 for E2E tests)playwright@<1.55.1: >=1.55.1Test plan