FEAT: adds prop so that the field value is only lowercase #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new onlyLowercase prop to the RhfCombobox component that automatically converts all input values to lowercase when enabled.
- Introduces an
onlyLowercaseboolean prop (defaults tofalse) to control lowercase transformation - Implements a
normalizeValuefunction to centralize the lowercase conversion logic - Ensures all value paths (input changes, value selection, default values, hidden input) consistently apply normalization
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ui/src/components/RhfCombobox/rhf-combobox.types.tsx | Adds the onlyLowercase optional boolean prop to the component's type definition |
| packages/ui/src/components/RhfCombobox/rhf-combobox.tsx | Implements the normalization logic with a memoized normalizeValue callback and applies it to all value handling paths including state initialization, value changes, input changes, and hidden input values |
| .changeset/shiny-ghosts-argue.md | Documents the feature addition for the changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rhf-combobox:Adds a prop to the component to work only with lowercase value