Skip to content

Conversation

@GabrielTozatti
Copy link
Collaborator

Description

Validation to the Liquid Stake FUEL cards to detect when an account/vault has pending transactions requiring signature. When a pending transaction exists, the card consistently displays a warning message across all mapped screens and layouts.

Summary

  • Mapped all screens where Liquid Stake FUEL (RIG) cards are displayed (desktop and mobile)
  • Implemented validation to detect pending signature transactions
  • Added consistent warning message "This account has pending transactions." to the card when applicable
  • Ensured the message is displayed uniformly across all mapped locations
  • Preserved current card behavior when no pending transactions exist
  • Verified responsive behavior on both desktop and mobile layouts

Screenshots

Example-4 Example-5

Video

Checklist

  • I reviewed my PR code before submitting
  • I ensured that the implementation is working correctly and did not impact other parts of the app
  • I implemented error handling for all actions/requests and verified how they will be displayed in the UI (or there was no error handling needed).
  • I mentioned the PR link in the task

Copy link
Member

@guimroque guimroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review - Summary

What was done

  • Added validation to detect pending transactions requiring signature on Liquid Stake FUEL cards
  • Implemented consistent warning message "This vault has pending transactions." across desktop and mobile layouts
  • Updated SVG formatting for powered-by-rig.svg (formatting only)
  • Modified CardLiquidStake and MobileDropdownLiquidStake components to display warning when applicable
  • Preserved existing card behavior when no pending transactions exist

Positive Points

  • Clear and focused implementation addressing the specific requirement
  • Consistent warning message across both desktop and mobile layouts
  • Proper responsive behavior maintained
  • Good use of existing design tokens and styling patterns
  • Clean component structure with proper prop passing

Issues Found

  • Missing import statement for poweredByRig asset
  • Inconsistent spacing in VStack component
  • Minor formatting inconsistency in one component

Total comments: 3 (0 critical, 2 important, 1 suggestion)

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-800.db1b4e2lqk8yl.amplifyapp.com

@pedroanastacio pedroanastacio merged commit b3e57c6 into staging Jan 14, 2026
0 of 2 checks passed
@pedroanastacio pedroanastacio deleted the tzt/fix/liquid-stake-cards branch January 14, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants