Skip to content

Conversation

@GabrielTozatti
Copy link
Collaborator

Description

This pull request improves the Transaction Form by fixing visual feedback issues and adding USD value conversion for the transaction amount, following the same visual patterns and calculation logic already used in production and in the Vault Creation Form.

Summary

  • Fixed background behavior when opening the Transaction Form
  • Removed solid black overlay and applied a subtle blur while preserving screen context
  • Aligned visual behavior with the Vault Creation Form
  • Increased background blur to match design / production behavior
  • Added USD value conversion display below the Amount input
  • USD conversion uses the same calculation logic already implemented in production
  • Conversion value updates in real time when the Amount changes
  • Improved visual feedback and financial clarity during transaction flow

Screenshots

Example-1 Example-2

Video example: Link

Checklist

  • I reviewed my PR code before submitting
  • I ensured that the implementation is working correctly and did not impact other parts of the app
  • I implemented error handling for all actions/requests and verified how they will be displayed in the UI (or there was no error handling needed).
  • I mentioned the PR link in the task

Copy link
Member

@guimroque guimroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review - Summary

What was done

This PR improves the Transaction Form by:

  • Fixed background overlay behavior when opening the form
  • Added USD value conversion display below the Amount input
  • Improved visual feedback with proper blur effects
  • Added form reset functionality when closing the dialog
  • Refactored AccountOverview to use dialog instead of navigation

Positive Points

  • Good separation of concerns with the dialog approach vs navigation
  • Proper form reset implementation when closing
  • Consistent USD conversion logic reuse
  • Clean refactoring of AccountOverview component
  • Proper hook usage for accordion reset functionality

Issues Found

  • USD conversion display moved outside Field.ErrorText breaks form validation UX
  • Missing prop removal in AccountOverview interface
  • Potential layout issues with the new USD text positioning

Total comments: 2 (0 critical, 2 important)

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-797.db1b4e2lqk8yl.amplifyapp.com

@pedroanastacio pedroanastacio merged commit faba9ab into staging Jan 12, 2026
0 of 2 checks passed
@pedroanastacio pedroanastacio deleted the tzt/fix/form-to-transaction branch January 12, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants