Cluster Meta Data by buralp · Pull Request #208 · inensus/MPManager

buralp · 2021-07-29T23:50:59Z

Added new feature named Cluster Meta Data to reach information that Energy Capacity, Registered Customers, Connected Meters on Mini Grid.
Created ClusterMetaDataListener.php to listen customer and meter events (created, deleted).
- increment registered customers count after added a new customer.
- decrement registered customers count after deleted a customer.
- increment connected meters count after added a new meter.
- decrement connected meters count after deleted a meter.
Created test files and tested all methods

93Kamuran · 2021-07-30T13:53:03Z

Please add explain what kind of changes you did with this PR.

alchalade · 2021-07-30T18:04:17Z

Website/htdocs/mpmanager/app/Http/Controllers/MiniGridController.php

    public function store(StoreMiniGridRequest $request): ApiResource
    {
        $miniGrid = $this->miniGrid::create($request->only('cluster_id', 'name'));
+        event('increment.connected.meters.count');


@buralp cluster_meta.connected_meters.increase would be a better name for it.

Please build your events like

base object (cluster_meta, address, person, ....)

property (name, gender, meter_id, ....)

intension ( increase, change, decrease, ..... )

alchalade · 2021-07-30T18:04:47Z

Website/htdocs/mpmanager/app/Models/ClusterMetaData.php

+
+class ClusterMetaData extends Model
+{
+    protected $guarded = [];


@buralp Please use ´BaseModel instead of ´Model.

alchalade · 2021-07-30T18:12:09Z

Website/htdocs/mpmanager/app/Listeners/ClusterMetaDataListener.php

+            '\App\Listeners\ClusterMetaDataListener@incrementConnectedMetersCount'
+        );
+        $events->listen(
+            'cluster_meta.connected_meters.decrement',


@buralp please use decrease instead of decrement

alchalade · 2021-07-30T18:12:33Z

Website/htdocs/mpmanager/app/Observers/MeterParameterObserver.php

        $meter->save();
-    }

+        event('cluster_meta.connected_meters.decrement', $meterParameter);


@buralp same here : decrease

alchalade · 2021-07-30T18:12:49Z

Website/htdocs/mpmanager/app/Observers/PersonObserver.php

        */
-
+        if ($person->is_customer == 1) {
+            event('cluster_meta.registered_customers.decrement', $person);


@buralp same decrease

alchalade · 2021-08-08T10:55:41Z

Website/htdocs/mpmanager/tests/Feature/ClusterMetaDataTest.php

+    }
+
+    /** @test */
+    public function delete_cluster_meta_data_object_after_deleted_a_miniGrid()


you are testing if eloquents delete function.

You are deleting ClusterMetaData object and expect that is deleted 🤔 .

What I understand from the function is; After you delete a mini-grid, the ClusterMetaDataobject will also be automatically deleted. Am I right?

yes you right. my mistake, i am changing ClusterMetaData to MiniGrid

alchalade · 2021-08-08T10:56:12Z

Website/htdocs/mpmanager/tests/Feature/ClusterMetaDataTest.php

+{
+    use RefreshDatabase;
+
+    /** @test */


@buralp please remove @test and add test_ prefix to each function name

alchalade · 2021-08-08T11:03:03Z

Website/htdocs/mpmanager/tests/Feature/ClusterMetaDataTest.php

+    }
+
+    /** @test */
+    public function decrement_connected_meters_count_after_deleted_a_meter()


@buralp please use decrease instead of decrement

alchalade · 2021-08-08T11:03:55Z

Website/htdocs/mpmanager/app/Listeners/ClusterMetaDataListener.php

+
+class ClusterMetaDataListener
+{
+    public function incrementConnectedMetersCount(MeterParameter $meterParameter): void


@buralp increase would be a better naming. Please change all increment 's with increase .

alchalade · 2021-08-08T11:06:39Z

Website/htdocs/mpmanager/database/factories/PersonFactory.php

            'birth_date' => $this->faker->date(),
            'sex' => $this->faker->randomKey(['male', 'female']),
-            'is_customer' => 1,
+            'is_customer' => 0,


@buralp What was the reason to change that?

because i want to check that is customer in PersonObserver.php

… Energy Capacity, Registered Customers, Connected Meters on Mini Grid

…ement Cluster Meta Data properties ( registered customers, connected meters )

…( Create miniGrid, Delete MiniGrid, Add Customer, Delete Customer, Add Meter, Delete Meter)

alchalade suggested changes Aug 8, 2021

View reviewed changes

buralp added 13 commits August 9, 2021 17:03

Created new feature named Cluster Meta Data to reach information that…

c2f23cf

… Energy Capacity, Registered Customers, Connected Meters on Mini Grid

Listen Events ( created, deleted ) via Observers to increment or decr…

6504b38

…ement Cluster Meta Data properties ( registered customers, connected meters )

Created test file for cluster meta data object and tested all methods…

2baf6a4

…( Create miniGrid, Delete MiniGrid, Add Customer, Delete Customer, Add Meter, Delete Meter)

Fixed failed tests

349a0c7

Fixed PHPCBF errors

86a9739

Fixed line exceed errors

d6b86fe

Fixed phpcs errors

b9d6de8

changed function names (increment to increase, decrement to decrease)

ed40025

changed Model with BaseModel

6853bd1

changed event name (increment to increase, decrement to decrease)

54e1f6e

changed function name createMarkingInformation to markerInformation

7bc2ffe

added test_ prefix to each function name and fixed wrong test function

5d709fb

Fixed phpcs errors

4f402ee

buralp force-pushed the cluster-meta-data branch from 36a5989 to 4f402ee Compare August 9, 2021 14:06

Conversation

buralp commented Jul 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

93Kamuran commented Jul 30, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

buralp Aug 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

buralp commented Jul 29, 2021 •

edited

Loading

buralp Aug 9, 2021 •

edited

Loading