cpio-archive: fix trailer for pax, bsd, and gnu#277
Open
mcandre wants to merge 7 commits intoindygreg:mainfrom
Open
cpio-archive: fix trailer for pax, bsd, and gnu#277mcandre wants to merge 7 commits intoindygreg:mainfrom
mcandre wants to merge 7 commits intoindygreg:mainfrom
Conversation
mcandre
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced
finish()to follow bsdcpio (libarchive) trailer logic more closely:This enables cpio-archive generated files to pass
pax -v <test.cpiowithout triggering early volume end warnings. In fact, the CPIO Payload is now MD5 equivalent to one generated bypkgbuild, as long as resource forks are included.Relates to #269
macOS
installercontinues to reject my cpio streams. But we're getting closer. The damage is now limited to the gzip stream, or more likely the Bom.