feat: add proxy support for codesigning rust package#212
feat: add proxy support for codesigning rust package#212austinsasko wants to merge 1 commit intoindygreg:mainfrom
Conversation
|
@indygreg it looks like Actions has an issue with one of the checks that is preventing my checksuite from passing fully. Is there any action to be taken for this PR to be ready for review, or is the issue just related to the "windows-2022, i686-pc-windows-msvc" build process for all current versions? |
indygreg
left a comment
indygreg
left a comment
There was a problem hiding this comment.
Adding HTTP proxy server is something I definitely want to do.
CI on main should be fixed now.
Could you please rebase and address the comments? Then we can get this merged.
| let proxy_uri: Uri = std::env::var("https_proxy").ok()?.parse().ok()?; | ||
| let mut proxy = Proxy::new(Intercept::All, proxy_uri); | ||
|
|
||
| let proxy_user = env::var_os("proxy_user"); | ||
| let proxy_password = env::var_os("proxy_password"); |
There was a problem hiding this comment.
Sometimes these environment variables are lowercase. Sometimes uppercase.
I believe the most reliable way to implement this code is to iterate through every environment variable, do a case insensitive compare and then collect into Option<T> along the way.
| anyhow = "1.0.99" | ||
| aws-config = { version = "1.8.5", optional = true } | ||
| aws-sdk-s3 = { version = "1.103.0", optional = true } | ||
| aws-smithy-client = { version = "0.56.1", features = ["rustls", "client-hyper"] } |
There was a problem hiding this comment.
Is there a reason we had to downgrade this crate?
2 participants
Creating a more up to date version to resolve merge conflicts and dated dependencies, dupe of #88