Add more type annotations to expansion helpers#254
Conversation
alexfikl
force-pushed
the
type-expansion
branch
from
4fec563 to
e46c5ce
Compare
sumpy/expansion/level_to_order.py
Outdated
| err_const_helmholtz: float = 100.0 | ||
| """Constant used in the Laplace truncation error.""" | ||
| scaling_const_helmholtz: float = 4.0 | ||
| """Constant :math:`C_{\text{helmscale}}` used in the Helmholtz truncation error.""" |
There was a problem hiding this comment.
Not sure I understood the difference between err_const_helmholtz and scaling_const_helmholtz. Do these docs make sense?
There was a problem hiding this comment.
Updated these a bit to correctly mention the variables in the main class docs, so it should be fine.. hopefully..
alexfikl
force-pushed
the
type-expansion
branch
from
e46c5ce to
54fa32b
Compare
sumpy/expansion/m2l.py
Outdated
| # FIXME: these seem to be sym.Expr in every usage here. Any other cases? | ||
| TranslationClassesDepData: TypeAlias = tuple[Any, ...] |
There was a problem hiding this comment.
Safe to try out tuple[sym.Expr, ...]?
There was a problem hiding this comment.
If it typechecks, feel free to make it sharper.
There was a problem hiding this comment.
Seems to work just fine. Updated in https://github.com/inducer/sumpy/compare/2e2360206cc7c51b9fa1f2631412382195587a1c..371cbcacd928780acabc1f8357bf486668bf03d2.
alexfikl
force-pushed
the
type-expansion
branch
from
54fa32b to
d39234f
Compare
alexfikl
force-pushed
the
type-expansion
branch
2 times, most recently
from
9875fce to
9c053e9
Compare
alexfikl
force-pushed
the
type-expansion
branch
from
9c053e9 to
2e23602
Compare
alexfikl
force-pushed
the
type-expansion
branch
from
2e23602 to
371cbca
Compare
|
@inducer This should pass the tests now™, so it's good to take a look at whenever you have the time. EDIT: I'm assuming that failure is because I |
alexfikl
force-pushed
the
type-expansion
branch
from
371cbca to
1712c39
Compare
inducer
force-pushed
the
type-expansion
branch
from
b8dc6b5 to
e512c84
Compare
|
Thx! |
2 participants
No description provided.