Merged
Conversation
inducer
force-pushed
the
expn-typing
branch
4 times, most recently
from
33c6cce to
888b730
Compare
alexfikl
reviewed
Oct 23, 2025
inducer
force-pushed
the
expn-typing
branch
5 times, most recently
from
77eb4f7 to
a5be2b1
Compare
alexfikl
reviewed
Oct 24, 2025
Collaborator
alexfikl
left a comment
alexfikl
left a comment
There was a problem hiding this comment.
Left a few nitpicks, but overall very nice 😁
inducer
force-pushed
the
expn-typing
branch
4 times, most recently
from
f2d13cc to
96a33bc
Compare
Owner
Author
|
inducer/pytential#288 confirms that this can pass pytential, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @alexfikl for awareness