Skip to content

Fix incorrect scaling of Yukawa kernel #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 4 commits into from
Sep 11, 2025
Merged

Fix incorrect scaling of Yukawa kernel #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2532fcb
Fix incorrect scaling of Yukawa kernel
inducer Mar 17, 2025
99dd452
Add get_pde_as_diff_op to doc
inducer Mar 24, 2025
1ca7cc6
Add a test for the jump relation to test kernel scaling
inducer Sep 11, 2025
154726e
Update baseline
inducer Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
298 changes: 298 additions & 0 deletions .basedpyright/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42150,6 +42150,264 @@
}
}
],
"./sumpy/test/geometries.py": [
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 20,
"endColumn": 60,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 21,
"endColumn": 41,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 28,
"endColumn": 38,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 28,
"endColumn": 38,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 28,
"endColumn": 36,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 14,
"endColumn": 22,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 4,
"endColumn": 11,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 4,
"endColumn": 10,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 4,
"endColumn": 11,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 28,
"endColumn": 35,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 8,
"endColumn": 18,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 8,
"endColumn": 24,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 16,
"endColumn": 24,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 26,
"endColumn": 34,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 36,
"endColumn": 44,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 16,
"endColumn": 25,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 27,
"endColumn": 36,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 38,
"endColumn": 47,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 8,
"endColumn": 16,
"lineCount": 1
}
},
{
"code": "reportUnusedExpression",
"range": {
"startColumn": 8,
"endColumn": 11,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 14,
"endColumn": 27,
"lineCount": 1
}
},
{
"code": "reportUnknownMemberType",
"range": {
"startColumn": 14,
"endColumn": 39,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 14,
"endColumn": 41,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 16,
"endColumn": 30,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 16,
"endColumn": 42,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 16,
"endColumn": 44,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 22,
"endColumn": 37,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 22,
"endColumn": 46,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 22,
"endColumn": 48,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 16,
"endColumn": 31,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 16,
"endColumn": 40,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 16,
"endColumn": 42,
"lineCount": 1
}
}
],
"./sumpy/test/test_codegen.py": [
{
"code": "reportUnknownMemberType",
Expand Down Expand Up @@ -49406,6 +49664,46 @@
"endColumn": 51,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 4,
"endColumn": 10,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 12,
"endColumn": 19,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 36,
"endColumn": 37,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 4,
"endColumn": 7,
"lineCount": 1
}
},
{
"code": "reportAny",
"range": {
"startColumn": 14,
"endColumn": 35,
"lineCount": 1
}
}
],
"./sumpy/test/test_matrixgen.py": [
Expand Down
5 changes: 3 additions & 2 deletions sumpy/kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ class Kernel(ABC):
.. automethod:: get_global_scaling_const
.. automethod:: get_args
.. automethod:: get_source_args
.. automethod:: get_pde_as_diff_op
"""

dim: int
Expand Down Expand Up @@ -676,15 +677,15 @@ def __init__(self, dim: int, yukawa_lambda_name: str = "lam") -> None:
expr = var("hankel_1")(0, var("I")*lam*r)
scaling_for_K0 = var("pi")/2*var("I") # noqa: N806

scaling = -1/(2*var("pi")) * scaling_for_K0
scaling = 1/(2*var("pi")) * scaling_for_K0
elif dim == 3:
# NOTE: to get the expression, we do the following and simplify
# 1. express K(1/2, lam r) as a modified spherical Bessel function
# k(0, lam r) using [3] and use expression for k(0, lam r) from [4]
# 2. or use (AS 10.2.17) directly
expr = var("exp")(-lam*r) / r

scaling = -1/(4 * var("pi")**2)
scaling = 1/(4 * var("pi"))
else:
raise NotImplementedError(f"unsupported dimension: '{dim}'")

Expand Down
Loading
Loading