Enable and fix PGH ruff rules

pyproject.toml

@@ -72,12 +72,13 @@ extend-select = [
     "I",   # flake8-isort
     "N",   # pep8-naming
     "NPY", # numpy
+    "PGH", # pygrep-hooks
     "Q",   # flake8-quotes
-    "UP",  # pyupgrade
     "RUF", # ruff
+    "SIM", # flake8-simplify
+    "TC",  # flake8-type-checking
+    "UP",  # pyupgrade
     "W",   # pycodestyle
-    "TC",
-    "SIM",
 ]
 extend-ignore = [
     "C90",  # McCabe complexity

pytools/__init__.py

@@ -716,7 +716,7 @@ def wrapper(*args):
             return wrapper
 
     if not args:
-        return _decorator  # type: ignore
+        return _decorator  # type: ignore[return-value]
     if callable(args[0]) and len(args) == 1:
         return _decorator(args[0])
     raise TypeError(

pytools/mpiwrap.py

@@ -6,21 +6,20 @@
 
 mpi4py.rc.initialize = False
 
-from mpi4py.MPI import *  # noqa pylint:disable=wildcard-import,wrong-import-position
+from mpi4py.MPI import *  # noqa: F403 pylint:disable=wildcard-import,wrong-import-position
 
 import pytools.prefork  # pylint:disable=wrong-import-position
 
 
 pytools.prefork.enable_prefork()
 
 
-# pylint: disable-next=undefined-variable
-if Is_initialized():    # type: ignore[name-defined,unused-ignore] # noqa
+if Is_initialized():  # type: ignore[name-defined] # noqa: F405
     raise RuntimeError("MPI already initialized before MPI wrapper import")
 
 
-def InitWithAutoFinalize(*args, **kwargs):  # noqa
-    result = Init(*args, **kwargs)  # noqa pylint:disable=undefined-variable
+def InitWithAutoFinalize(*args, **kwargs):  # noqa: N802
+    result = Init(*args, **kwargs)  # noqa: F405
     import atexit
-    atexit.register(Finalize)  # noqa pylint:disable=undefined-variable
+    atexit.register(Finalize)  # # noqa: F405
     return result

pytools/py_codegen.py

@@ -27,7 +27,7 @@
 from importlib.util import MAGIC_NUMBER as BYTECODE_VERSION
 from types import FunctionType, ModuleType
 
-from pytools.codegen import (  # noqa
+from pytools.codegen import (  # noqa: F401
     CodeGenerator as CodeGeneratorBase,
     Indentation,
     remove_common_indentation,