Skip to content

Add more types to primitives#274

Merged
inducer merged 4 commits intoinducer:mainfrom
alexfikl:type-primitives
Aug 31, 2025
Merged

Add more types to primitives#274
inducer merged 4 commits intoinducer:mainfrom
alexfikl:type-primitives

Conversation

@alexfikl
Copy link
Collaborator

Some remaining issues (for another time):

  • From MultiVector not having all the methods typed (map and stuff)
  • From Derivative not being typed (all that dnabla machinery).
  • Typing these made a lot of errors in other places, so they might not be quite right. Although the stats on baseline.json show a lot more errors are removed, so probably not that big of an issue.

@inducer
Copy link
Owner

inducer commented Aug 30, 2025

Heh! I'd started down a similar path as a result of the #273 failures, but only got as far as inducer/pytools#320 (and the associated release) plus some scattered changes on my local machine. I've pushed them to #275. If you like, feel free to grab them and incorporate them here.

@alexfikl alexfikl force-pushed the type-primitives branch 2 times, most recently from 93ac897 to 9cc498d Compare August 31, 2025 11:58
@alexfikl
Copy link
Collaborator Author

Heh! I'd started down a similar path as a result of the #273 failures, but only got as far as inducer/pytools#320 (and the associated release) plus some scattered changes on my local machine. I've pushed them to #275. If you like, feel free to grab them and incorporate them here.

Cherry picked all the changes that weren't already in here from #275. Let me know if anything is missing!

There are probably some more changes in pytools that would fix things here. I'll try to take a look at that.

@alexfikl alexfikl marked this pull request as ready for review August 31, 2025 12:02
@inducer inducer merged commit 834bb2f into inducer:main Aug 31, 2025
8 checks passed
@inducer
Copy link
Owner

inducer commented Aug 31, 2025

Thx!

@alexfikl alexfikl deleted the type-primitives branch September 1, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants