Avoid duplicating arrays

.github/workflows/ci.yml

@@ -31,25 +31,7 @@ jobs:
         -   uses: actions/checkout@v4
         -   uses: crate-ci/typos@master
 
-    pylint:
-        name: Pylint
-        runs-on: ubuntu-latest
-        steps:
-        -   uses: actions/checkout@v4
-        -
-            uses: actions/setup-python@v5
-            with:
-                python-version: '3.x'
-        -   name: "Main Script"
-            run: |
-                export EXTRA_INSTALL="git+https://github.com/inducer/arraycontext"
-                curl -L -O https://tiker.net/ci-support-v0
-                . ci-support-v0
-                build_py_project_in_conda_env
-                run_pylint "$(basename $GITHUB_REPOSITORY)" test/test_*.py examples
-
-    mypy:
-        name: Mypy
+    basedpyright:
         runs-on: ubuntu-latest
         steps:
         -   uses: actions/checkout@v4
@@ -63,8 +45,9 @@ jobs:
                 curl -L -O https://tiker.net/ci-support-v0
                 . ./ci-support-v0
                 build_py_project_in_conda_env
-                python -m pip install basedmypy
-                ./run-mypy.sh
+                python -m pip install pytest
+                python -m pip install basedpyright
+                basedpyright
 
     pytest:
         name: Conda Pytest

.gitlab-ci.yml

@@ -34,17 +34,6 @@ Python 3 POCL Examples:
   except:
   - tags
 
-Pylint:
-  script:
-  - export PY_EXE=python3
-  - EXTRA_INSTALL="pyopencl mpi4py jax[cpu] pygments"
-  - curl -L -O https://gitlab.tiker.net/inducer/ci-support/raw/main/prepare-and-run-pylint.sh
-  - . ./prepare-and-run-pylint.sh ${CI_PROJECT_NAME} test/test_*.py examples
-  tags:
-  - python3
-  except:
-  - tags
-
 Ruff:
   script: |
     pipx install ruff
@@ -54,14 +43,14 @@ Ruff:
   except:
   - tags
 
-Mypy:
+BasedPyright:
   script: |
     curl -L -O https://tiker.net/ci-support-v0
     . ./ci-support-v0
     export EXTRA_INSTALL="git+https://github.com/inducer/arraycontext"
     build_py_project_in_venv
-    python -m pip install basedmypy mpi4py
-    ./run-mypy.sh
+    python -m pip install basedpyright mpi4py pytest
+    basedpyright
   tags:
   - python3
   except:

examples/advection.py

@@ -156,6 +156,7 @@ def test_advection_convergence(order, flux_type):
         op = AdvectionOperator(discr, c=1, flux_type=flux_type,
                                dg_ops=dg_ops)
         result = op.apply(u)
+        result = pt.transform.Deduplicator()(result)
 
         prog = pt.generate_loopy(result, cl_device=queue.device)
 

pyproject.toml

@@ -19,7 +19,6 @@ classifiers = [
     "Intended Audience :: Developers",
     "Intended Audience :: Other Audience",
     "Intended Audience :: Science/Research",
-    "License :: OSI Approved :: MIT License",
     "Programming Language :: Python",
     "Programming Language :: Python",
     "Programming Language :: Python :: 3",
@@ -35,7 +34,7 @@ dependencies = [
     "bidict",
     "immutabledict",
     "loopy>=2020.2",
-    "pytools>=2024.1.21",
+    "pytools>=2025.1.5",
     "pymbolic>=2024.2",
     "typing_extensions>=4",
     "orderedsets",
@@ -144,6 +143,33 @@ module = [
 # We'll be getting rid of it, no point in fixing it.
 ignore_errors = true
 
+
+[tool.basedpyright]
+reportImplicitStringConcatenation = "none"
+reportUnnecessaryIsInstance = "none"
+reportUnusedCallResult = "none"
+reportExplicitAny = "none"
+
+# This reports even cycles that are qualified by 'if TYPE_CHECKING'. Not what
+# we care about at this moment.
+# https://github.com/microsoft/pyright/issues/746
+reportImportCycles = "none"
+
+# Some errors get flagged in CI, but not locally. This makes it awkward to
+# include those in the baseline, so they get ignored with 'pyright: ignore'.
+# Local runs now flag this as unnecessary. Downgrading to hint to avoid
+# circular complaints.
+reportUnnecessaryTypeIgnoreComment = "hint"
+
+pythonVersion = "3.10"
+pythonPlatform = "All"
+
+ignore = [
+    # We'll be getting rid of it, no point in fixing it.
+    "pytato/raising.py",
+]
+
+
 [tool.typos.default]
 extend-ignore-re = [
   "(?Rm)^.*(#|//)\\s*spellchecker:\\s*disable-line$"

pytato/analysis/__init__.py

@@ -26,10 +26,10 @@
 THE SOFTWARE.
 """
 
-from typing import TYPE_CHECKING, Any, Never, overload
+from typing import TYPE_CHECKING, Any, overload
 
 from orderedsets import FrozenOrderedSet
-from typing_extensions import Self
+from typing_extensions import Never, Self
 
 from loopy.tools import LoopyKeyBuilder
 from pymbolic.mapper.optimize import optimize_mapper
@@ -54,7 +54,7 @@
 if TYPE_CHECKING:
     from collections.abc import Iterable, Mapping
 
-    import pytools
+    import pytools.tag
 
     from pytato.distributed.nodes import DistributedRecv, DistributedSendRefHolder
     from pytato.loopy import LoopyCall