Add make_distributed_send_ref_holder#479
Merged
inducer merged 2 commits intoinducer:mainfrom Feb 6, 2024
Merged
Conversation
Collaborator
Author
|
@inducer @matthiasdiener How's this look? |
Collaborator
|
LGTM, thanks! |
inducer
reviewed
Jan 26, 2024
pytato/distributed/nodes.py
Outdated
| ) -> DistributedSendRefHolder: | ||
| """Make a :class:`DistributedSendRefHolder` object.""" | ||
| return DistributedSendRefHolder( | ||
| send=send, passthrough_data=passthrough_data, tags=tags) |
Owner
There was a problem hiding this comment.
Call _get_default_tags here. (Probably also for make_distributed_send above and make_distributed_recv below.)
majosm
force-pushed
the
make-dist-send-ref-holder-function
branch
from
c0e1cee to
d7bebff
Compare
inducer
force-pushed
the
make-dist-send-ref-holder-function
branch
from
d7bebff to
aabb344
Compare
Owner
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a function to make a
DistributedSendRefHolder, so we don't need to call its__init__method directly in inducer/grudge#285. (Calling__init__doesn't play well with theCreatedAttags added in #284.)