Skip to content

test mirgecom examples in CI #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 5 commits into from
Mar 3, 2022
Merged

test mirgecom examples in CI #221

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aac4bc7
also test mirgecom examples in CI
matthiasdiener Mar 2, 2022
55b1244
reorder
matthiasdiener Mar 2, 2022
ccf501e
also test production
matthiasdiener Mar 2, 2022
22f7193
remove production test (won't work without emirge)
matthiasdiener Mar 2, 2022
de84ea5
only test examples for mirgecom
matthiasdiener Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ jobs:
sed -i "/mpi4py/ d" requirements.txt
fi
build_py_project_in_conda_env
test_py_project

if test "$DOWNSTREAM_PROJECT" = "mirgecom"; then
# Test main branch
# Only test examples, not pytest tests, as those take too much time.
Copy link
Owner

@inducer inducer Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not add a separate job for examples instead of not running mirgecom pytest at all?

Copy link
Collaborator

@MTCam MTCam Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo, running the pytest suite for the downstream project is of little value. It also takes a really long time (only 30 minutes for mirgecom@main, but pushing an hour+ once NS+AV tests are added). I think making sure the examples run and get the correct answers is a sufficient amount of testing to claim the current development does not break mirgecom.

Copy link
Owner

@inducer inducer Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fair. You're on the receiving end of those potentially breaking changes, so if you say it's OK, I'm happy to trust you and take my shorter CI times. :)

examples/run_examples.sh ./examples
else
test_py_project
fi


# vim: sw=4