Conversation
There was a problem hiding this comment.
Pull request overview
This PR appears focused on addressing Ruff-related cleanup across the codebase (import style, simplifications), along with a small tweak to lint configuration and baselines.
Changes:
- Normalize imports (e.g., switch to
from pytools import obj_array, adjustpyopenclcltypes import style). - Apply small simplifications (comprehensions/one-line returns, remove redundant locals/
passstatements). - Update linting configuration (
per-file-ignores) and refresh the basedpyright baseline.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
test/test_tree_of_boxes.py |
Switch obj_array import style. |
test/test_tree.py |
Simplify test decorator return. |
test/test_traversal.py |
Switch obj_array import style. |
test/test_fmm.py |
Remove one parametrized test case. |
test/test_cost_model.py |
Replace loop building mismatches with a list comprehension. |
pyproject.toml |
Add Ruff per-file ignore entries for S102. |
boxtree/tree_build_kernels.py |
Replace loops with fields.extend(...) generator patterns. |
boxtree/tree.py |
Minor simplifications (one-line return; inline ListOfListsBuilder return). |
boxtree/tools.py |
Adjust cltypes import style. |
boxtree/pyfmmlib_integration.py |
Consolidate pytools imports. |
boxtree/fmm.py |
Remove pass from docstring-only method body. |
boxtree/cost.py |
Remove pass from abstract methods (docstring-only). |
.basedpyright/baseline.json |
Update baseline entries/ranges. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.