Skip to content

Comments

Ruf152#111

Merged
inducer merged 2 commits intomainfrom
ruf152
Feb 21, 2026
Merged

Ruf152#111
inducer merged 2 commits intomainfrom
ruf152

Conversation

@inducer
Copy link
Owner

@inducer inducer commented Feb 21, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 21, 2026 04:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears focused on addressing Ruff-related cleanup across the codebase (import style, simplifications), along with a small tweak to lint configuration and baselines.

Changes:

  • Normalize imports (e.g., switch to from pytools import obj_array, adjust pyopencl cltypes import style).
  • Apply small simplifications (comprehensions/one-line returns, remove redundant locals/pass statements).
  • Update linting configuration (per-file-ignores) and refresh the basedpyright baseline.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/test_tree_of_boxes.py Switch obj_array import style.
test/test_tree.py Simplify test decorator return.
test/test_traversal.py Switch obj_array import style.
test/test_fmm.py Remove one parametrized test case.
test/test_cost_model.py Replace loop building mismatches with a list comprehension.
pyproject.toml Add Ruff per-file ignore entries for S102.
boxtree/tree_build_kernels.py Replace loops with fields.extend(...) generator patterns.
boxtree/tree.py Minor simplifications (one-line return; inline ListOfListsBuilder return).
boxtree/tools.py Adjust cltypes import style.
boxtree/pyfmmlib_integration.py Consolidate pytools imports.
boxtree/fmm.py Remove pass from docstring-only method body.
boxtree/cost.py Remove pass from abstract methods (docstring-only).
.basedpyright/baseline.json Update baseline entries/ranges.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@inducer inducer enabled auto-merge (rebase) February 21, 2026 05:00
@inducer inducer merged commit 2892a88 into main Feb 21, 2026
12 checks passed
@inducer inducer deleted the ruf152 branch February 21, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant