Add nmem_from_xml_buffer #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new utility function nmem_from_xml_buffer to simplify copying xmlBuffer data into NMEM-managed memory. The PR refactors existing code that was duplicating this pattern and reorganizes XML-related NMEM utilities into a dedicated source file.
Key changes:
- Added new
nmem_from_xml_bufferfunction that encapsulates the pattern of copying xmlBuffer contents to NMEM - Moved
nmem_text_node_cdatafunction fromnmemsdup.cto newnmem_xml.cfile for better code organization - Refactored
xml_match.candsolr.cto use the new utility function, reducing code duplication
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| win/makefile | Added nmem_xml.obj to the build targets for Windows |
| src/yaz/nmem_xml.h | Added declaration for new nmem_from_xml_buffer function |
| src/xml_match.c | Refactored to use nmem_from_xml_buffer and added include for nmem_xml.h |
| src/solr.c | Replaced direct xmlBuffer handling with nmem_from_xml_buffer call |
| src/nmemsdup.c | Removed nmem_text_node_cdata function (moved to nmem_xml.c) and corrected include directive |
| src/nmem_xml.c | New file containing XML-specific NMEM utilities including the new nmem_from_xml_buffer function |
| src/Makefile.am | Added nmem_xml.c to source files, updated version info, and removed trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.