Skip to content

Use rpm macros to avoid postinst failures in a container #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
adamdickmeiss merged 23 commits into from
Jan 10, 2026
Merged

Use rpm macros to avoid postinst failures in a container #58

adamdickmeiss merged 23 commits into from
Jan 10, 2026
+52 −48

Conversation

@jakub-id
Copy link
Contributor

@jakub-id jakub-id commented Jan 9, 2026

No description provided.

@jakub-id jakub-id requested a review from Copilot January 9, 2026 06:42
Copilot AI reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the RPM spec file's post-installation scripts to use systemd macros, improving compatibility with container environments where systemd may not be available. The changes ensure that package installation won't fail in containers while maintaining proper functionality in standard deployments.

  • Replaces manual systemd commands with RPM systemd macros that handle container environments gracefully
  • Improves error handling in user/group creation and cleanup scripts with proper null checks and fallback values
  • Updates dependency from libyazpp6-devel to libyazpp7-devel

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jakub-id jakub-id requested a review from adamdickmeiss January 9, 2026 07:31
adamdickmeiss and others added 4 commits January 9, 2026 23:57
@adamdickmeiss
Update metaproxy.spec
b154ce2 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adamdickmeiss
Update metaproxy.spec
9557094 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adamdickmeiss
SERVER_HOME by defualt /var/lib/metaproxy
2d56cc0
@adamdickmeiss
Do not ignore errors during install/upgrade
f16ddca
@adamdickmeiss adamdickmeiss requested a review from Copilot January 9, 2026 23:07
Copilot AI reviewed Jan 9, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adamdickmeiss adamdickmeiss requested a review from Copilot January 10, 2026 14:30
Copilot AI reviewed Jan 10, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

adamdickmeiss and others added 5 commits January 10, 2026 16:08
@adamdickmeiss
Update metaproxy.spec
79040a6 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adamdickmeiss
Update metaproxy.spec
c4b7dbf 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adamdickmeiss
Update rpm/metaproxy.service
bbfb617 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adamdickmeiss
use rhel in test
156c065
@adamdickmeiss
Merge remote-tracking branch 'origin/container-systemd' into containe…
75308d3 
…r-systemd
@adamdickmeiss adamdickmeiss requested a review from Copilot January 10, 2026 15:24
Copilot AI reviewed Jan 10, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adamdickmeiss
Update metaproxy.spec
5a880d5 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
adamdickmeiss and others added 2 commits January 10, 2026 16:29
@adamdickmeiss
Update metaproxy.spec
7992d04 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adamdickmeiss
logrotate: handle systemd not running
a9e6edc
@adamdickmeiss adamdickmeiss requested a review from Copilot January 10, 2026 18:20
Copilot AI reviewed Jan 10, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

adamdickmeiss and others added 4 commits January 10, 2026 20:05
@adamdickmeiss
Update metaproxy.spec
7040848 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adamdickmeiss
Update metaproxy.spec
ee9caa3 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@adamdickmeiss
Update Requires, URL
e5be59d
@adamdickmeiss
Add CentOS 10
2fc41e9
@adamdickmeiss adamdickmeiss requested a review from Copilot January 10, 2026 19:16
Copilot AI reviewed Jan 10, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

adamdickmeiss
adamdickmeiss approved these changes Jan 10, 2026
View reviewed changes
Copy link
Contributor

@adamdickmeiss adamdickmeiss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, tested on CentOS 10 VM

@adamdickmeiss adamdickmeiss merged commit 0c10377 into master Jan 10, 2026
2 checks passed
@adamdickmeiss adamdickmeiss deleted the container-systemd branch January 10, 2026 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@adamdickmeiss adamdickmeiss adamdickmeiss approved these changes

Assignees

@adamdickmeiss adamdickmeiss

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakub-id @adamdickmeiss