Skip to content

Remove output redirection from shell scripts #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
losolio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove output redirection from shell scripts #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
run: |
mkdir -p logs html_summaries json_results
docker compose up -d spark
docker compose run --rm --no-deps plan_executor ./execute_all.sh 'http://spark:8080/fhir' r4 'html|json|stdout'
docker compose run --rm --no-deps plan_executor ./execute_all.sh 'http://spark:8080/fhir' r4 'html|json|stdout' 2>&1 | tee logs/execute_all.log
docker compose logs spark > logs/backend.log
-
name: Combine test results
Expand Down
14 changes: 14 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,20 @@ Run a DSTU2 Suite
$ bundle exec rake crucible:execute[http://hapi.fhir.org/baseDstu2,dstu2,TransactionAndBatchTest]
```

## Logging Output

The shell scripts output directly to stdout/stderr. To save logs to a file while also displaying output, use `tee`:

```
$ ./execute_all.sh http://localhost:8080/fhir r4 'html|json|stdout' 2>&1 | tee logs/execute_all.log
```

To redirect output to a file only (silent):

```
$ ./execute_all.sh http://localhost:8080/fhir r4 'html|json|stdout' > logs/execute_all.log 2>&1
Comment on lines +48 to +57
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logging examples write to logs/execute_all.log, but logs/ may not exist anymore (and this PR explicitly removes automatic log creation). As written, the commands will fail with “No such file or directory” if logs/ hasn’t been created. Consider updating the examples to include mkdir -p logs (or mention that callers must create the directory first).

Copilot uses AI. Check for mistakes.
```

## Adding a New Test Suite

1. Fork the repo
Expand Down
2 changes: 1 addition & 1 deletion execute_all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ FHIR_ENDPOINT_URL=$1
FHIR_VERSION=$2
TEST_OUTPUT=$3

bundle exec rake crucible:execute_all[$FHIR_ENDPOINT_URL,$FHIR_VERSION,$TEST_OUTPUT] > logs/execute_all.log 2>&1
bundle exec rake crucible:execute_all[$FHIR_ENDPOINT_URL,$FHIR_VERSION,$TEST_OUTPUT]


2 changes: 1 addition & 1 deletion execute_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ FHIR_VERSION=$2
TEST=$3
TEST_OUTPUT=$4

bundle exec rake crucible:execute[$FHIR_ENDPOINT_URL,$FHIR_VERSION,$TEST,,$TEST_OUTPUT] > logs/execute_$TEST.log 2>&1
bundle exec rake crucible:execute[$FHIR_ENDPOINT_URL,$FHIR_VERSION,$TEST,,$TEST_OUTPUT]
2 changes: 1 addition & 1 deletion list_all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ set -e

FHIR_VERSION=$1

bundle exec rake crucible:list_all[$FHIR_VERSION] > logs/list_all.log 2>&1
bundle exec rake crucible:list_all[$FHIR_VERSION]