Auth: Prepare client sync and settings for authorization code flow#13
Open
Auth: Prepare client sync and settings for authorization code flow#13
Conversation
Contributor
losolio
commented
Mar 24, 2026
losolio
commented
- Add RedirectUris and PostLogoutRedirectUris to ClientDefinition
- Add LoginPath to AuthEndpointSettings
- Implement authorization_code grant in ClientSyncInitializer
- Update README with new configuration options
There was a problem hiding this comment.
Pull request overview
Prepares Ignis.Auth configuration and client synchronization for an upcoming OpenIddict authorization code flow, including new client URI settings and updated documentation/config defaults.
Changes:
- Extend auth settings/client definitions with redirect URIs, post-logout redirect URIs, and a login path.
- Update client sync to register OpenIddict permissions/URIs for
authorization_codeclients. - Adjust integration test configuration precedence to avoid leaked environment variables overriding test config.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Ignis.Api.Tests/AuthConfigurationTests.cs | Ensures test in-memory config wins over environment variables. |
| src/Ignis.Auth/Services/ClientSyncInitializer.cs | Adds authorization_code handling and syncs redirect URIs to OpenIddict. |
| src/Ignis.Auth/README.md | Documents new settings and provides updated configuration examples. |
| src/Ignis.Auth/AuthSettings.cs | Adds LoginPath, RedirectUris, and PostLogoutRedirectUris settings. |
| src/Ignis.Api/appsettings.json | Adds AuthSettings.Endpoints.LoginPath to app configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add RedirectUris and PostLogoutRedirectUris to ClientDefinition - Add LoginPath to AuthEndpointSettings - Implement authorization_code grant in ClientSyncInitializer - Update README with new configuration options
losolio
force-pushed
the
feature/auth/prep-code-flow
branch
from
aee2f62 to
9b3df9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.