Skip to content

Cancel timer in async mode #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elbrujohalcon merged 3 commits into from
Feb 8, 2026
Merged

Cancel timer in async mode #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8cdd0d2
Make cancel_timer async as its result is not needed
NelsonVides Feb 8, 2026
cb2bba8
Upgrade CI
NelsonVides Feb 8, 2026
29d0a5a
Use faster system_time(second) too
NelsonVides Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/workflows/erlang.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,25 +10,27 @@ on:
workflow_dispatch: {}

jobs:

build:

runs-on: ubuntu-24.04

name: OTP:${{matrix.otp}}
strategy:
matrix:
otp: ['28', '27']
rebar3: ['3.26']
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- uses: erlef/setup-beam@v1
id: setup-beam
with:
version-type: strict
version-file: .tool-versions
otp-version: ${{matrix.otp}}
rebar3-version: ${{matrix.rebar3}}
- name: Restore _build
uses: actions/cache@v4
uses: actions/cache@v5
with:
path: _build
key: _build-cache-for-os-${{runner.os}}-otp-${{steps.setup-beam.outputs.otp-version}}-rebar3-${{steps.setup-beam.outputs.rebar3-version}}-hash-${{hashFiles('rebar.lock')}}
- name: Restore rebar3's cache
uses: actions/cache@v4
uses: actions/cache@v5
with:
path: ~/.cache/rebar3
key: rebar3-cache-for-os-${{runner.os}}-otp-${{steps.setup-beam.outputs.otp-version}}-rebar3-${{steps.setup-beam.outputs.rebar3-version}}-hash-${{hashFiles('rebar.lock')}}
Expand All @@ -39,9 +41,9 @@ jobs:
- name: Run tests and verifications
run: rebar3 test
- name: Upload code coverage
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
with:
file: "_build/test/covertool/worker_pool.covertool.xml"
files: ./_build/test/covertool/worker_pool.covertool.xml
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
verbose: true
2 changes: 0 additions & 2 deletions .tool-versions
View file
Open in desktop

This file was deleted.

4 changes: 1 addition & 3 deletions src/wpool_pool.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,7 @@ function_location(Function, Location) ->
task(undefined) ->
[];
task({_TaskId, Started, Task}) ->
Time =
calendar:datetime_to_gregorian_seconds(
calendar:universal_time()),
Time = erlang:system_time(second),
[{task, Task}, {runtime, Time - Started}].

%% @doc Set next within the worker pool record. Useful when using
Expand Down
2 changes: 1 addition & 1 deletion src/wpool_utils.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ task_init(Task,
task_end(undefined) ->
erlang:erase(wpool_task);
task_end(TimerRef) ->
_ = erlang:cancel_timer(TimerRef),
_ = erlang:cancel_timer(TimerRef, [{async, true}, {info, false}]),
erlang:erase(wpool_task).

%% @doc Adds default parameters to a pool configuration
Expand Down