Added "Error" priority level and optional TAG pass-through and Demo Application #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to add option for scrolling/not scrolling
Author
|
Hi. I notice our repos have diverged a bit since this was forked - i this a pull request you'd like to see accepted? If so, I can get it up to date. |
Contributor
|
Hey @alberthynek, yeah, there were a few other PRs merged into master since you forked it, so your version might be a bit outdated. If you could update your changes so that it's on top of the current code in master, that would be much easier to review. Thanks! |
Need to add option for scrolling/not scrolling
Conflicts: src/main/java/com/inaka/galgo/Galgo.java src/main/java/com/inaka/galgo/GalgoOptions.java src/main/java/com/inaka/galgo/GalgoService.java
Author
|
Hey @quiqueqs - It should be good to go now (apologies for the number of commits that took) |
Contributor
|
Thanks @alberthynek - I'll take a look at it during next week. |
alberthynek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors can now be displayed on-screen in a different color.
Error color can be set the same way regular text color is set, and defaults to red.
When logged as an error, LogCat is invoked with .e rather than .i
Logging can pass your own tag through to LogCat (defaults to previous behaviour)
Also includes new demo application - allows for setting of galgo options and seeing the result - as well as providing a sample codebase