[iOS] Fix detection of devices via Service UUID (CircuitCubes, WeDo2)#138
Open
vicocz wants to merge 2 commits intoimurvai:masterfrom
Open
[iOS] Fix detection of devices via Service UUID (CircuitCubes, WeDo2)#138vicocz wants to merge 2 commits intoimurvai:masterfrom
vicocz wants to merge 2 commits intoimurvai:masterfrom
Conversation
vicocz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added processing of 0x06 advertisment data type so as devices such as CircuitCubes and WeDo2 are properly discovered by scanning.
Additionally there seemed to be issue with characteristics writes on iOS for Circuit Cubes:
Obviously iOS is sensitive if write type does not match the one defined by a characteristic being written. So changed to
WriteNoResponseAsyncand it seems to be working on iOS, Android and Windows.Resolves: #134
Seems to be related to #114 as well.