Reset send attemp for a channel if write was successful [Control+]#127
Closed
vicocz wants to merge 3 commits intoimurvai:masterfrom
Closed
Reset send attemp for a channel if write was successful [Control+]#127vicocz wants to merge 3 commits intoimurvai:masterfrom
vicocz wants to merge 3 commits intoimurvai:masterfrom
Conversation
vicocz
changed the title
J0EK3R
pushed a commit
to J0EK3R/brickcontroller2
that referenced
this pull request
May 20, 2025
* Run unit tests for BrickController core project * GH workflows use windows-2025 which contains maui 9 workloads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During my work on #125 I've noticed (thx to port output command feedback) that a channel value is written 10 times (if it does not change in the meantime) due to the fact send attempts are not reset. Additionally write delay was 60ms which means that for hubs with several ports single round might take e.g. 9 ports * 60 ms. It might delay application of a channel value by circa 400 ms in some teoretical situations.
Additionally I've inverted IFs so as there are less
return truelines.Tried to optimize it:
Dev tested on my TechnicHub.