Fix inner exception for the first round of a sequence play#122
Open
vicocz wants to merge 1 commit intoimurvai:masterfrom
Open
Fix inner exception for the first round of a sequence play#122vicocz wants to merge 1 commit intoimurvai:masterfrom
vicocz wants to merge 1 commit intoimurvai:masterfrom
Conversation
J0EK3R
added a commit
to J0EK3R/brickcontroller2
that referenced
this pull request
Apr 9, 2025
* JK: fixed DuploTrainHubDevice * added a mechanism to resend data after a certain period of time has elepsed --------- Co-authored-by: J0EK3R <J0EK3R3.3@WIN11>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is inner exception, hidden to user, which regularly occurs when a sequence is played for the first time and
kvp.Value.StartTimeMsis null as it was updated in_sequencesonly. THe only consequence of this failure is IMHO the timing, the sequence is effectively started 50 ms later. So nearly no impact for user.