Add Metafields to Products and Collections#112
Merged
imsujan276 merged 1 commit intoimsujan276:mainfrom Jan 28, 2025
Merged
Conversation
kammcs
changed the title
Owner
|
Thank you for adding this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as discussed in Issue 111, here is my pull request that adds metafield support to all all queries related to products and collections.
This adds an optional list of metafield identifiers on these functions, which as passed to the query, then parsed in the fromGraphJson inside the model classes.
Tested extensively against my store, and has worked great.