Skip to content

feat: Generator/Literal#19

Merged
imsenyu merged 18 commits intomasterfrom
feat/jsesc
Mar 29, 2025
Merged

feat: Generator/Literal#19
imsenyu merged 18 commits intomasterfrom
feat/jsesc

Conversation

@imsenyu
Copy link
Owner

@imsenyu imsenyu commented Mar 25, 2025

  • StringLiteral
  • NumericLiteral
  • DirectiveLiteral

Copy link
Owner Author

@imsenyu imsenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 5569757 Previous: 5ccb3ef Ratio
BM_BabelParse:rxjs/dist/bundles/rxjs.umd.min.js/min_time:1.000 2.939138206315755 ms/iter 2.3823719846154163 ms/iter 1.23
BM_BabelParse:react-dom/cjs/react-dom.production.min.js/min_time:1.000 3.4057033711583813 ms/iter 4.200026045180655 ms/iter 0.81
BM_BabelParse:rxjs/dist/bundles/rxjs.umd.js/min_time:1.000 2.1944333666146623 ms/iter 2.192256495282975 ms/iter 1.00
BM_BabelParse:@babel/parser/lib/index.js/min_time:1.000 4.36995382608697 ms/iter 4.354298422360235 ms/iter 1.00
BM_BabelParse:three/build/three.min.js/min_time:1.000 8.519061151515196 ms/iter 9.064297273292025 ms/iter 0.94
BM_BabelParse:antd/dist/antd.min.js/min_time:1.000 21.420126359375402 ms/iter 22.226799857142915 ms/iter 0.96
BM_BabelParse:typescript/lib/typescript.js/min_time:1.000 66.3988830952381 ms/iter 68.22684614285804 ms/iter 0.97
BM_BabelGenerate:rxjs/dist/bundles/rxjs.umd.min.js/min_time:1.000 1.124895975845425 ms/iter 1.1118466544293937 ms/iter 1.01
BM_BabelGenerate:react-dom/cjs/react-dom.production.min.js/min_time:1.000 1.6564628239436474 ms/iter 1.629343859171591 ms/iter 1.02
BM_BabelGenerate:rxjs/dist/bundles/rxjs.umd.js/min_time:1.000 1.2667286293900337 ms/iter 1.2463605943810099 ms/iter 1.02
BM_BabelGenerate:@babel/parser/lib/index.js/min_time:1.000 2.7040718636363072 ms/iter 2.684679525046389 ms/iter 1.01
BM_BabelGenerate:three/build/three.min.js/min_time:1.000 5.77410147580655 ms/iter 5.772344357142725 ms/iter 1.00
BM_BabelGenerate:antd/dist/antd.min.js/min_time:1.000 15.958106402298858 ms/iter 16.96975078571397 ms/iter 0.94
BM_BabelGenerate:typescript/lib/typescript.js/min_time:1.000 37.680148432432794 ms/iter 39.8910091470588 ms/iter 0.94

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

Test Results

5 818 tests  ±0   5 660 ✅ +27   5m 53s ⏱️ -13s
    1 suites ±0       0 💤 ± 0 
    1 files   ±0     158 ❌  - 27 

For more details on these failures, see this check.

Results for commit 5569757. ± Comparison against base commit 5ccb3ef.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 81.23393% with 73 lines in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (5ccb3ef) to head (5569757).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/npm_modules/jsesc/jsesc.hpp 77.70% 35 Missing ⚠️
src/base/number.hpp 86.95% 9 Missing ⚠️
src/babel/babel-helper-fixtures/index.hpp 74.19% 8 Missing ⚠️
src/babel/babel-generator/printer.hpp 37.50% 5 Missing ⚠️
src/base/javascript.hpp 68.75% 5 Missing ⚠️
src/babel/babel-generator/generators/base.hpp 76.92% 3 Missing ⚠️
src/babel/babel-generator/test/index.hpp 75.00% 3 Missing ⚠️
src/benchmark/generate.hpp 0.00% 2 Missing ⚠️
src/babel/babel-generator/generators/jsx.hpp 50.00% 1 Missing ⚠️
src/babel/babel-parser/index.hpp 50.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   84.27%   84.51%   +0.23%     
==========================================
  Files          88       90       +2     
  Lines       17008    17342     +334     
  Branches     2926     2994      +68     
==========================================
+ Hits        14333    14656     +323     
- Misses       2675     2686      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imsenyu imsenyu changed the title feat: generator/jsesc feat: Generator/Literal Mar 26, 2025
@imsenyu imsenyu merged commit 0e9520d into master Mar 29, 2025
6 of 7 checks passed
@imsenyu imsenyu deleted the feat/jsesc branch March 29, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant