This repository was archived by the owner on Jan 26, 2026. It is now read-only.
Reserving values for additional payload types#37
Merged
agavra merged 4 commits intoimprint-serde:mainfrom Jul 8, 2025
Merged
Conversation
dosubot
bot
added
size:S
agavra
reviewed
Jul 1, 2025
Contributor
agavra
left a comment
agavra
left a comment
There was a problem hiding this comment.
Thanks @expanded-for-real -- I feel like you're already the most knowledgeable contributor to Imprint after all your work on the Java format so it's great to have you stamp (or should I say fingerprint 😆) on the main project.
Left some comments inline
Contributor
|
Not sure why the bench CI/CD isn't working but this obviously doesn't effect that so I'll dig into that another time. We can ignore it for now. |
reorganize time types and fix int representation for timestamp from int64 to int32
Contributor
Author
|
@agavra let me know if everything looks good here and I can go ahead and start this work on the java side. |
agavra
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserving values for complex types as described in - imprint-serde/imprint-java#25