Skip to content
This repository was archived by the owner on Jan 26, 2026. It is now read-only.

remove optionality of field dictionary#33

Merged
cadonna merged 1 commit intomainfrom
optional_field_dict
Jun 5, 2025
Merged

remove optionality of field dictionary#33
cadonna merged 1 commit intomainfrom
optional_field_dict

Conversation

@agavra
Copy link
Contributor

@agavra agavra commented Jun 4, 2025

fixes #25

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jun 4, 2025
@github-actions
Copy link

github-actions bot commented Jun 4, 2025

📊 Benchmark Comparison Report

This pull request includes Criterion benchmarks comparing performance to the main branch.
This comment will automatically update as the benchmarks are re-run on each commit.

The table below shows relative ratios and timing stats for each benchmark group:

group                main                                   pr
-----                ----                                   --
ops/merge            1.00  1428.3±26.27ns        ? ?/sec    1.10  1573.3±16.55ns        ? ?/sec
ops/project          1.00    586.3±7.97ns        ? ?/sec    1.02    598.3±7.19ns        ? ?/sec
serde/deserialize    1.00    271.2±3.60ns        ? ?/sec    1.03    279.2±1.93ns        ? ?/sec
serde/serialize      1.08    276.1±7.45ns        ? ?/sec    1.00   256.5±20.00ns        ? ?/sec

✅ Benchmarks completed successfully.

🧠 Notes:

  • These benchmarks are not a pass/fail gate and are informative only.
  • Use this as a signal to review performance-sensitive changes.
  • Results may be unreliable due to GHA runner hardware variance.
  • If results indicate a significant performance regression, run the benchmarks locally to confirm.

Reported by the benchmark CI bot

Copy link
Contributor

@cadonna cadonna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @agavra !

LGTM!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 5, 2025
@cadonna cadonna merged commit 5d921ab into main Jun 5, 2025
2 checks passed
@cadonna cadonna deleted the optional_field_dict branch June 5, 2025 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make Field Dict required

2 participants