Add correct abs symbol plus alias #280
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
I've looked up the characters, and it turns out the one we have in waterproof-vscode is the one known as "divides", so I suggest we keep that one and adjust the exercise sheet instead, if possible. @jim-portegies Edit: Nvm, it's not used as absolute value here, so that doesn't make sense necessarily. Maybe the question is: Do we want two different vertical bars in our context, one for divides and one for absolute values? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
waterproof-exercises/ch5_sequences_sum_rule.mvwe make use of unicode symbol｜(U+FF5C) for absolute value notation.The current symbol in the symbols.json file is
∣(U+2223) which does not work with the new notation (|, the pipe character, however does also work).