Skip to content

Mapping #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
DikieDick wants to merge 59 commits into
base: main
Choose a base branch
from
Draft

Mapping #30

DikieDick wants to merge 59 commits into from

Conversation

@DikieDick
Copy link
Contributor

@DikieDick DikieDick commented Oct 8, 2025 •
edited
Loading

Roadmap:

  • Code cell at the start of the document does not work (assigned to @XyntaxCS)
  • Inserting does not yet work in prosemirror
    a. Inserting above fails to insert the proper newline after the inserted node?
    b. Inserting below also does not always insert the proper newline after the inserted node.
  • Test mapping features from blocks instead of document constructor.
  • Parse empty text nodes in .v file case (assigned to @DikieDick)
  • Should we rename innerRange to contentRange? Also renamed range to tagRange as per suggestion by @XyntaxCS. (@DikieDick)
  • Inserting does not yet work in mapping?
  • Inserting below after input area inserts correctly but then mapping is off.
    a. It does work when the node selection is a markdown cell.
  • We might not be able to fully remove the skull feature, as codemirror steps are applied and then send to prosemirror.
  • Unit test coverage.
  • Problem: Inserting below than moving into the inserted cell and inserting code cell again below crashes.
  • Use more efficient searching algorithms. We have the invariant that the childnodes in the tree are sorted, hence we can use binary search, or use some more efficient tree searching algorithm (@DikieDick research). Tree method findNodeByProsePos uses binary search already.
  • Check wpWrapIn and wpLift
  • Why do we have pmRange and prosemirrorStart/prosemirrorEnd?

Resolves #33 and #28

DikieDick and others added 30 commits September 13, 2025 13:55
@DikieDick
Update to include changes from wp-vscode mapping_reconstruct
e373315
@DikieDick
Fix codeblocks
1bdc605
@DikieDick
Add types for markdown-it
d201ef7
@DikieDick
Update extract using ranges to include offset from parent
6f73f72
@DikieDick
Remove FileFormat
dc6a30f
@DikieDick
Refactor SwitchableView, Remove Completions, Remove Translation
17b5525
@raulTUe
extra libraries necessary for testing nodeupdate added
ff72e94
@DikieDick
Update
5bca0b8
@DikieDick
Don't apply transaction when step caused error
4a9573d
@DikieDick
Fix block utils
930af44
@DikieDick
Get rid off hardcoded node type names, insert commands refactored.
81b9378 
The refactoring of the insert commands means that the logic is now
way simpler, as our document assumptions have been simplified.

There was also a bug that we inserted 3 code blocks at a time (I think
because we were inserting on the edge of a node??), there is a TODO
there since I don't fully understand the cause of that bug yet.
@DikieDick
Merge branch 'update-docs' into mapping
00ef538
@DikieDick
Implement newline nodes into schema and blocks
ff7cffc
@DikieDick
Add node delete functionality
d88865e
@DikieDick
Insert above works, insert below needs work
bf24236
@DikieDick
Fix vFile parser and default markdown parser, move markdown parser to…
b6d5b30 
… editor
@DikieDick
Add serializer, remove preProcessor step, allow editor to serialize f…
38a47a8 
…ull document
@DikieDick
Move coqdoc testing to waterproof-vscode
f7054c7
@DikieDick
Remove old document translator test
6708344
@DikieDick
Fix typing issue in utils.test.ts and use correct math translation fu…
6b57b17 
…nction in mathinline.test.ts
@DikieDick
Fix newlines in markdown parser and preliminary test
8802eb2
@DikieDick
Reexport slices from prosemirror
f2b50f3
@DikieDick
update commands
a3bad2f
@DikieDick
Set 'group' property, do not allow empty input/hint
e746ce0
@DikieDick
Let esbuild set 'DEBUG' variable
3e6cd36
@DikieDick
Update commands
d4f20bf
@DikieDick
Remove skull
6b6e31c
@DikieDick
Merge branch 'main' into mapping
288ec10
@DikieDick
Add prosemirror dev tools
8ca5761
@DikieDick
Update utils for Pieter
81e8fc6
@pimotte pimotte mentioned this pull request Nov 3, 2025
Merged
@DikieDick DikieDick mentioned this pull request Nov 3, 2025
Open
@DikieDick DikieDick linked an issue Nov 14, 2025 that may be closed by this pull request
Refactor Mapping and/or Architecture #28
Open
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 17, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
48.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change mapping to a tree Refactor Mapping and/or Architecture

4 participants

@DikieDick @raulTUe @XyntaxCS