-
Notifications
You must be signed in to change notification settings - Fork 2
imotionsApi v2.9.0 - major update of how AOI metrics are stored/computed in online to try to fasten the process. #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for new AOI format not working correctly
Test Results 1 files ± 0 56 suites +1 10s ⏱️ -1s Results for commit ff11986. ± Comparison against base commit 9b23a92. This pull request removes 52 and adds 60 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
cecilieesj
reviewed
Jan 13, 2026
cecilieesj
approved these changes
Jan 14, 2026
cecilieesj
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature additions:
Renaming all functions containing "AOI" to follow a better convention (ie. getAOIs becomes getAois).
Addition of some caching inside privateAoiFormatting() so AOIs for an online study only get retrieved once (there is only one endpoint at the study level so the result will always be the same).
Addition of an optional localPath parameter to imConnection() to allow us to save metrics and downloaded signals for online locally (if provided)
Updating uploadAoiMetrics() to work with online at a respondent level and write back metrics locally. Also creating some new functions (privateUploadAoiMetrics(), privateUploadAoiMetrics.imRespondent() and privateUploadAoiMetrics.imSegment()) to improve the workflow.
Updating privateDownloadData() to not delete local files in case a localPath was added. These files will be removed at the end of the whole processing (ie when all respondents/stimuli have been processed).
Updating getAoiRespondentMetrics() to work with online and retrieve the newly stored metrics using uploadAoiMetrics().
Updating getFile() to store and retrieve local downloaded signals in case a localPath was added.
Bug fixes:
Fixing a small issue inside privateAoiFormatting() with the new AOIs from online (with respondent timeline) that were filtered out by mistake.
Fixing a small issue inside privateGetAoiDetails and privateAoiFiltering.imRespondent() where broken in/out data would make the functions crash. Also changing the order of the filtering inside privateAoiFiltering.imRespondent() so we do not make unneeded calls to privateGetAoiDetails().