Skip to content

Conversation

@dpedu
Copy link

@dpedu dpedu commented May 5, 2019

I tested my site with this tool and encountered this:

$ drupwn enum https://dpedu.io/

        ____
       / __ \_______  ______ _      ______
      / / / / ___/ / / / __ \ | /| / / __ \
     / /_/ / /  / /_/ / /_/ / |/ |/ / / / /
    /_____/_/   \__,_/ .___/|__/|__/_/ /_/
                     /_/

[-] Version not specified, trying to identify it
Traceback (most recent call last):
  File "/Users/dave/code/drupwn/testenv/bin/drupwn", line 7, in <module>
    exec(compile(f.read(), __file__, 'exec'))
  File "/Users/dave/code/drupwn/drupwn", line 43, in <module>
    Fingerprinter(request, logger).fingerprint(config)
  File "/Users/dave/code/drupwn/engine/Fingerprinter.py", line 28, in fingerprint
    config["version"] = float(version.group(0))
AttributeError: 'NoneType' object has no attribute 'group'
$

This changes avoids this error using some checks and correctly shows the Please specify a version if version detection fails:

$ drupwn enum https://dpedu.io/

        ____
       / __ \_______  ______ _      ______
      / / / / ___/ / / / __ \ | /| / / __ \
     / /_/ / /  / /_/ / /_/ / |/ |/ / / / /
    /_____/_/   \__,_/ .___/|__/|__/_/ /_/
                     /_/

[-] Version not specified, trying to identify it

[-] The automatic detection failed. Please specify a version
$

@immunIT immunIT self-assigned this May 6, 2019
@immunIT
Copy link
Collaborator

immunIT commented May 10, 2019

Hi @dpedu,

Could you please review your pull request according to our CONTRIBUTING file?

==> https://github.com/immunIT/drupwn/blob/master/CONTRIBUTING.md

Best,

@dpedu dpedu changed the base branch from master to develop May 11, 2019 00:17
@dpedu dpedu closed this May 11, 2019
@dpedu
Copy link
Author

dpedu commented May 11, 2019

Follow up in #34.

@immunIT immunIT removed their assignment Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants