Switch configuration storage from .env to SQLite (breaking change) #540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Entity Framework Core packages to project. - Implemented ConfigDbContext for managing account overrides. - Created AccountOverrideEntity and corresponding DTO for data representation. - Developed SqliteAccountOverrideStore for data access and manipulation. - Introduced AccountOverrideMerger for applying overrides to account settings. - Updated ConfigController to handle account override retrieval and updates. - Enhanced Program.cs to configure the SQLite database context. - Added tests for account override functionality in ConfigController and AccountOverrideMerger. - Updated Dockerfile and docker-compose files to support SQLite data persistence.
- Introduced IAccountOverrideChangeNotifier and its implementation for notifying clients of account override changes. - Updated ConfigController to handle SSE for account override events and version retrieval. - Enhanced home-page and admin components to support real-time updates and management of account overrides. - Added functionality to refresh asset loading upon override changes.
- Introduced GeneralSettingsDto for managing general settings. - Implemented IGeneralSettingsStore and SqliteGeneralSettingsStore for data access. - Added GeneralSettingsChangeNotifier for real-time updates on general settings changes. - Enhanced ConfigController to handle retrieval and updates of general settings via API. - Updated Program.cs to initialize the GeneralSettings table in SQLite. - Integrated live updates in the home-page and admin components for general settings changes.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces the current .env-based configuration with a SQLite-backed config store.
SQLite was chosen for simplicity, zero external dependencies, and to enable editing configuration while the container is running via the existing web interface at /admin.
Breaking change
This is an intentional breaking change:
The goal is to avoid dual config sources and long-term maintenance complexity.
Notes / limitations
Compatibility path
If this approach is considered too disruptive, the implementation can be refactored to:
That was intentionally deferred to keep this PR focused unless required.
Scope
This PR is limited to configuration storage changes only. No unrelated behavior or features are introduced.