Skip to content

Add second large object test to check v8 non-fast properties #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markerikson merged 2 commits into from
Oct 27, 2025
+37 −34
Merged

Add second large object test to check v8 non-fast properties #1187

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
964e3b3
Add second large object test to check v8 non-fast properties
markerikson Oct 27, 2025
8b341a5
Tweak perf output formatting
markerikson Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 37 additions & 34 deletions perf-testing/immutability-benchmarks.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ function createInitialState(arraySize = BENCHMARK_CONFIG.arraySize) {
name: `name-${i}`,
isActive: i % 2 === 0
})),
largeObject: createLargeObject(BENCHMARK_CONFIG.largeObjectSize),
largeObject1: createLargeObject(BENCHMARK_CONFIG.largeObjectSize1),
largeObject2: createLargeObject(BENCHMARK_CONFIG.largeObjectSize2),
api: {
queries: {},
provided: {
Expand All @@ -62,7 +63,8 @@ const BENCHMARK_CONFIG = {
iterations: 1,
arraySize: 100,
nestedArraySize: 10,
largeObjectSize: 1000,
largeObjectSize1: 1000,
largeObjectSize2: 3000,
multiUpdateCount: 5,
reuseStateIterations: 10
}
Expand Down Expand Up @@ -104,8 +106,12 @@ const update = index => ({
type: "test/updateItem",
payload: {id: index, value: index, nestedData: index}
})
const updateLargeObject = index => ({
type: "test/updateLargeObject",
const updateLargeObject1 = index => ({
type: "test/updateLargeObject1",
payload: {value: index}
})
const updateLargeObject2 = index => ({
type: "test/updateLargeObject2",
payload: {value: index}
})
const concat = index => ({
Expand Down Expand Up @@ -174,10 +180,12 @@ const actions = {
remove,
filter,
update,
updateLargeObject,
concat,
mapNested,
// dash-named fields to improve readability in benchmark results

"update-largeObject1": updateLargeObject1,
"update-largeObject2": updateLargeObject2,
"update-high": updateHigh,
"update-multiple": updateMultiple,
"remove-high": removeHigh,
Expand Down Expand Up @@ -332,11 +340,22 @@ const vanillaReducer = (state = createInitialState(), action) => {
)
}
}
case "test/updateLargeObject": {
case "test/updateLargeObject1": {
return {
...state,
largeObject1: {
...state.largeObject1,
[`propertyAdded${action.payload.value}`]: {
id: action.payload.value
}
}
}
}
case "test/updateLargeObject2": {
return {
...state,
largeObject: {
...state.largeObject,
largeObject2: {
...state.largeObject2,
[`propertyAdded${action.payload.value}`]: {
id: action.payload.value
}
Expand Down Expand Up @@ -462,8 +481,14 @@ const createImmerReducer = produce => {
item.nested.data = action.payload.nestedData
break
}
case "test/updateLargeObject": {
draft.largeObject[`propertyAdded${action.payload.value}`] = {
case "test/updateLargeObject1": {
draft.largeObject1[`propertyAdded${action.payload.value}`] = {
id: action.payload.value
}
break
}
case "test/updateLargeObject2": {
draft.largeObject2[`propertyAdded${action.payload.value}`] = {
id: action.payload.value
}
break
Expand Down Expand Up @@ -597,7 +622,8 @@ function createBenchmarks() {
"update-high",
"remove",
"remove-high",
"updateLargeObject"
"update-largeObject1",
"update-largeObject2"
]
for (const action of reuseActions) {
summary(function() {
Expand Down Expand Up @@ -1191,13 +1217,6 @@ function printOverallVersionRankings(versionScores) {
return
}

console.log(
"\nMethodology: Lower geometric mean = better overall performance"
)
console.log(
"(Geometric mean is standard for benchmarking as it handles multiplicative performance differences)"
)

console.log("\n┌──────┬─────────────────────┬─────────────────┬───────────┐")
console.log("│ Rank │ Version │ Geometric Mean │ Scenarios │")
console.log("├──────┼─────────────────────┼─────────────────┼───────────┤")
Expand All @@ -1216,22 +1235,6 @@ function printOverallVersionRankings(versionScores) {
}

console.log("└──────┴─────────────────────┴─────────────────┴───────────┘")

// Highlight top performers
if (versionScores.length >= 3) {
console.log("\nTop Overall Performers:")
for (let i = 0; i < Math.min(10, versionScores.length); i++) {
const score = versionScores[i]
const [versionName, freezeIndicator] = score.version.split("|")
const shortName = shortenVersionName(versionName)
console.log(
` ${i +
1}. ${shortName} (${freezeIndicator}) - ${score.geometricMean.toFixed(
2
)}x average`
)
}
}
}

function printBenchmarkSummaryTable(benchmarks) {
Expand Down
Loading