Pagination improvements #31
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit converts the
pagesobservable to an array for a better binding experience, and adds alimitedPagesobservable array that is constrained to contain onlypaginationLimitpages as per #22.The second commit adds a
blanksarray to each page in thepagesobservable array introduced above whose length is the amount of elements for that page that are missing for it to haveperPageelements (i.e. 0 for all pages except the last one, for which it equalsperPage-[pageElementCount]). The view can then bind to it in order to complete these missing entries and avoid the annoying table resize jumps when switching to and from it.