Draft
Conversation
ggabernet
commented
Dec 9, 2025
| db_cloned <- foreach::foreach(gp=1:n_groups, | ||
| .final=dplyr::bind_rows, | ||
| .inorder=TRUE, | ||
| .packages="scoper", |
Contributor
Author
There was a problem hiding this comment.
Not entirely sure if this line is needed or not
ggabernet
commented
Dec 9, 2025
| std::string s = as<std::string>(seqs[i]); | ||
| for (int p = 0; p < L; ++p) { | ||
| uint8_t c = code_char(s[p]); | ||
| if (c == 255) stop("Only A,C,G,T,N,? are allowed"); |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| if (c == 255) stop("Only A,C,G,T,N,? are allowed"); | |
| if (c == 255) stop("Only A,C,G,T,N,? are allowed"); |
Can we print here the sequence with the "bad characters" and say it contains not allowed. Consider removing sequences containing not allowed characters or running hierarchicalClones with IUPAC=True (link to documentation).
Consider how long does it take to check how many sequences have non-supported characters, and inform the users on the number of sequences containing non-supported characters already at the beginning of hierarchicalClones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.